Print number passed when giving up #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gweddington , thanks for the contribution. Did you see #41 (an old issue by @CodaFi from 2015)? Could you paste in some sample output here? Then we can discuss more of the pros and cons. This is a big enough change where we should think carefully before merging. |
|
This doesn't add log output if the test fails, it adds log output if the testing routine neither passes nor fails. If we |
|
It's been a while since this patch has seen significant discussion, and it has fallen behind. I'm going to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Added a printCond call to show the number of passed test cases when giving up
Why merge this pull request?
imho, it is beneficial to see how many passed when giving up before a failing case was found
What's worth discussing about this pull request?
What downsides are there to merging this pull request?
More verbose log output, if that's a downside.